fix(eks)!: send http traffic on NLB to port 80 on cluster#810
Merged
Conversation
A bug was sending all incoming traffic on the NLB to the port 443 on the cluster, whether it was http or https. This seems to have been working anyway in most cases because traefik is able to receive ssl and non-ssl on the same port. This commit fixes this behavior and sends incomming http traffic to the port 80 on the cluster. This change might break custom (but bad) ingress configurations that would expect all traffic to come on port 443.
acampergue-camptocamp
approved these changes
Nov 10, 2021
This was referenced Nov 10, 2021
Merged
This was referenced May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug was sending all incoming traffic on the NLB to the port 443 on the
cluster, whether it was http or https. This seems to have been working
anyway in most cases because traefik is able to receive ssl and non-ssl on
the same port.
This commit fixes this behavior and sends incomming http traffic to the port
80 on the cluster. This change might break custom (but bad) ingress
configurations that would expect all traffic to come on port 443.